Conversation
ricardoV94
force-pushed
the
add_softmax_math
branch
from
19f6066 to
97341bb
Compare
Codecov Report
@@ Coverage Diff @@
## main #5279 +/- ##
=======================================
Coverage 80.40% 80.41%
=======================================
Files 82 82
Lines 14126 14132 +6
=======================================
+ Hits 11358 11364 +6
Misses 2768 2768
|
twiecki
approved these changes
Dec 22, 2021
Member
Author
|
Some scary looking errors on windows, most likely triggered by the new Aesara version: https://github.com/pymc-devs/pymc/runs/4605536352?check_suite_focus=true#step:7:21 aesara-devs/aesara#701 would be my first guess |
michaelosthege
requested changes
Jan 7, 2022
Member
michaelosthege
left a comment
michaelosthege
left a comment
There was a problem hiding this comment.
This PR is blocked by aesara-devs/aesara#707 and will be delayed until we can upgrade to an Aesara release that includes a fix.
ricardoV94
force-pushed
the
add_softmax_math
branch
from
97341bb to
8af7d80
Compare
ricardoV94
commented
Jan 20, 2022
| def softmax(x, axis=None): | ||
| # Ignore vector case UserWarning issued by Aesara. This can be removed once Aesara | ||
| # drops that warning | ||
| with warnings.catch_warnings(): |
Member
Author
There was a problem hiding this comment.
I checked locally that this does not screw up UserWarnings elsewhere
michaelosthege
approved these changes
Jan 20, 2022
twiecki
approved these changes
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds softmax and log_softmax wrappers to the new Aesara Ops which accept the axis argument. The wrappers are there just to suppress the deprecation warnings issue on the Aesara side.
Closes #4226